patrick/WoofWare.PawPrint
1
0
Fork 0
mirror of https://github.com/Smaug123/WoofWare.PawPrint synced 2025-10-06 06:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implement another comparison case (#74)

Browse Source
This commit is contained in:
Patrick Stevens
2025-06-27 19:49:20 +01:00
committed by GitHub
parent 641040509f
commit 84df17295b
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
WoofWare.PawPrint/EvalStackValueComparisons.fs
View File

@@ -85,7 +85,14 @@ module EvalStackValueComparisons =
failwith "TODO: comparison of unsigned nativeint with int32" failwith "TODO: comparison of unsigned nativeint with int32"
| EvalStackValue.Float var1, EvalStackValue.Float var2 -> not (var1 <= var2) | EvalStackValue.Float var1, EvalStackValue.Float var2 -> not (var1 <= var2)
| EvalStackValue.Float _, _ -> failwith $"Cgt.un invalid for comparing %O{var1} with %O{var2}" | EvalStackValue.Float _, _ -> failwith $"Cgt.un invalid for comparing %O{var1} with %O{var2}"
| EvalStackValue.ManagedPointer var1, EvalStackValue.ManagedPointer var2 -> failwith "TODO" | EvalStackValue.ManagedPointer var1, EvalStackValue.ManagedPointer var2 ->
// I'm going to be stricter than the spec and simply ban every pointer comparison except those with null,
// pending a strong argument to fully support this.
match var1, var2 with
| ManagedPointerSource.Null, ManagedPointerSource.Null -> false
| ManagedPointerSource.Null, _ -> true
| _, ManagedPointerSource.Null -> true
| _, _ -> failwith $"I've banned this case: {var1} vs {var2}"
| EvalStackValue.ObjectRef var1, EvalStackValue.ObjectRef var2 -> | EvalStackValue.ObjectRef var1, EvalStackValue.ObjectRef var2 ->
// According to the spec, cgt.un is verifiable on ObjectRefs and is used to compare with null. // According to the spec, cgt.un is verifiable on ObjectRefs and is used to compare with null.
// A direct comparison between two object refs is not specified, so we treat it as a pointer comparison. // A direct comparison between two object refs is not specified, so we treat it as a pointer comparison.