From b9deec098f35919b9ad77baa6b11b7593473d488 Mon Sep 17 00:00:00 2001 From: ylemkimon Date: Sun, 7 Apr 2019 18:15:05 +0900 Subject: [PATCH] Load fonts before running screenshotter (#1891) --- dockers/screenshotter/screenshotter.js | 16 ++++++++---- test/screenshotter/test.html | 36 +++++++++++++++++++++----- 2 files changed, 40 insertions(+), 12 deletions(-) diff --git a/dockers/screenshotter/screenshotter.js b/dockers/screenshotter/screenshotter.js index 5c8feff1..85a47fc5 100644 --- a/dockers/screenshotter/screenshotter.js +++ b/dockers/screenshotter/screenshotter.js @@ -384,18 +384,17 @@ function takeScreenshot(key) { function loadMath() { if (!opts.reload && driverReady) { - driver.executeAsyncScript( - "var callback = arguments[arguments.length - 1]; " + + driver.executeScript( "handle_search_string(" + - JSON.stringify("?" + itm.query) + ", callback);") + JSON.stringify("?" + itm.query) + ");") .then(waitThenScreenshot); } else if (opts.coverage) { // collect coverage before reloading collectCoverage().then(function() { - return driver.get(url).then(waitThenScreenshot); + return driver.get(url).then(loadFonts); }); } else { - driver.get(url).then(waitThenScreenshot); + driver.get(url).then(loadFonts); } } @@ -408,6 +407,13 @@ function takeScreenshot(key) { }); } + function loadFonts() { + driver.executeAsyncScript( + "var callback = arguments[arguments.length - 1]; " + + "load_fonts(callback);") + .then(waitThenScreenshot); + } + function waitThenScreenshot() { driverReady = true; if (opts.wait) { diff --git a/test/screenshotter/test.html b/test/screenshotter/test.html index 671b01bd..5ba4827c 100644 --- a/test/screenshotter/test.html +++ b/test/screenshotter/test.html @@ -31,7 +31,35 @@