patrick/KaTeX
1
0
Fork 0
mirror of https://github.com/Smaug123/KaTeX synced 2025-10-05 19:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename Screenshotter -> screenshotter (#1573)

Browse Source 
Fix #1570
This commit is contained in:
Erik Demaine
2018-08-10 06:29:16 -04:00
committed by ylemkimon
parent bd0ac91378
commit 881d780287
6 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/config.yml
View File

@@ -29,7 +29,7 @@ screenshotter: &screenshotter
- run: - run:
name: Verify screenshots and generate diffs and new screenshots name: Verify screenshots and generate diffs and new screenshots
command: node dockers/Screenshotter/screenshotter.js --selenium-ip localhost -b $CIRCLE_JOB --verify --diff --new command: node dockers/screenshotter/screenshotter.js --selenium-ip localhost -b $CIRCLE_JOB --verify --diff --new
- store_artifacts: - store_artifacts:
path: test/screenshotter/new path: test/screenshotter/new

2
CONTRIBUTING.md
View File

@@ -97,7 +97,7 @@ You can view the report in `coverage/lcov-report/index.html`.
To ensure the final output looks good, we screenshot different expressions. To ensure the final output looks good, we screenshot different expressions.
These tests can be run by using the These tests can be run by using the
[Screenshotter docker](https://github.com/Khan/KaTeX/tree/master/dockers/Screenshotter). [screenshotter docker](https://github.com/Khan/KaTeX/tree/master/dockers/screenshotter).
The screenshot tests should be run if you add anything more significant than The screenshot tests should be run if you add anything more significant than
individual symbols. These tests are not automatically run, so please remember! individual symbols. These tests are not automatically run, so please remember!

8
dockers/Screenshotter/README.md → dockers/screenshotter/README.md
View File

@@ -21,7 +21,7 @@ are encouraged to reproduce the steps from `screenshotter.sh`
manually. Example run for Firefox: manually. Example run for Firefox:
container=$(docker run -d -P selenium/standalone-firefox:2.46.0) container=$(docker run -d -P selenium/standalone-firefox:2.46.0)
node dockers/Screenshotter/screenshotter.js -b firefox -c ${container} node dockers/screenshotter/screenshotter.js -b firefox -c ${container}
# possibly repeat the above command as often as you need, then eventually # possibly repeat the above command as often as you need, then eventually
docker stop ${container} docker stop ${container}
docker rm ${container} docker rm ${container}
@@ -33,7 +33,7 @@ For Chrome, simply replace both occurrences of `firefox` with `chrome`.
It is possible to run `screenshotter.js` without the use of Docker: It is possible to run `screenshotter.js` without the use of Docker:
yarn add selenium-webdriver yarn add selenium-webdriver
node dockers/Screenshotter/screenshotter.js node dockers/screenshotter/screenshotter.js
This will generate screenshots using the Firefox installed on your system. This will generate screenshots using the Firefox installed on your system.
Browsers other than Firefox can be targeted using the `--browser` option. Browsers other than Firefox can be targeted using the `--browser` option.
@@ -62,8 +62,8 @@ to specify a list of cases which are not being processed.
Examples: Examples:
node dockers/Screenshotter/screenshotter.js -i Sqrt,SqrtRoot node dockers/screenshotter/screenshotter.js -i Sqrt,SqrtRoot
dockers/Screenshotter/screenshotter.sh --exclude=GreekLetters dockers/screenshotter/screenshotter.sh --exclude=GreekLetters
# How to run screenshotter tests # How to run screenshotter tests

0
dockers/Screenshotter/screenshotter.js → dockers/screenshotter/screenshotter.js
View File

0
dockers/Screenshotter/screenshotter.sh → dockers/screenshotter/screenshotter.sh
View File

2
package.json
View File

@@ -72,7 +72,7 @@
"test:jest:update": "jest --updateSnapshot", "test:jest:update": "jest --updateSnapshot",
"test:jest:coverage": "jest --coverage", "test:jest:coverage": "jest --coverage",
"test:screenshots": "yarn test:screenshots:update --verify", "test:screenshots": "yarn test:screenshots:update --verify",
"test:screenshots:update": "yarn prestart && dockers/Screenshotter/screenshotter.sh", "test:screenshots:update": "yarn prestart && dockers/screenshotter/screenshotter.sh",
"test:perf": "yarn prestart && NODE_ENV=test node test/perf-test.js", "test:perf": "yarn prestart && NODE_ENV=test node test/perf-test.js",
"clean": "rm -rf dist/ node_modules/", "clean": "rm -rf dist/ node_modules/",
"clean-install": "yarn clean && yarn", "clean-install": "yarn clean && yarn",