Rename .value to .text or .color where applicable. (#1606)

* Update comment for defineFunction handler.

* Rename .value to .text in all token-style ParseNodes.

* Rename symbolNode's .value to .text.

* Rename color-token's .value to .color.

test/__snapshots__/katex-spec.js.snap

@@ -25,7 +25,7 @@ exports[`A begin/end parser should grab \\arraystretch 1`] = `
                     "start": 36
                   },
                   "mode": "math",
-                  "value": "a"
+                  "text": "a"
                 }
               ]
             }
@@ -51,7 +51,7 @@ exports[`A begin/end parser should grab \\arraystretch 1`] = `
                     "start": 38
                   },
                   "mode": "math",
-                  "value": "b"
+                  "text": "b"
                 }
               ]
             }
@@ -79,7 +79,7 @@ exports[`A begin/end parser should grab \\arraystretch 1`] = `
                     "start": 41
                   },
                   "mode": "math",
-                  "value": "c"
+                  "text": "c"
                 }
               ]
             }
@@ -105,7 +105,7 @@ exports[`A begin/end parser should grab \\arraystretch 1`] = `
                     "start": 43
                   },
                   "mode": "math",
-                  "value": "d"
+                  "text": "d"
                 }
               ]
             }
@@ -146,7 +146,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0,
     "style": {
     },
-    "value": "a",
+    "text": "a",
     "width": 0.52859
   },
   {
@@ -189,7 +189,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0,
     "style": {
     },
-    "value": "b",
+    "text": "b",
     "width": 0.42917
   },
   {
@@ -227,7 +227,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "=",
+            "text": "=",
             "width": 0.89444
           }
         ],
@@ -277,7 +277,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0.05556,
     "style": {
     },
-    "value": "c",
+    "text": "c",
     "width": 0.43276
   },
   {
@@ -315,7 +315,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "+",
+            "text": "+",
             "width": 0.89444
           }
         ],
@@ -365,7 +365,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0.16667,
     "style": {
     },
-    "value": "d",
+    "text": "d",
     "width": 0.52049
   },
   {
@@ -403,7 +403,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "+",
+            "text": "+",
             "width": 0.89444
           },
           {
@@ -418,7 +418,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "+",
+            "text": "+",
             "width": 0.89444
           }
         ],
@@ -468,7 +468,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0.05556,
     "style": {
     },
-    "value": "e",
+    "text": "e",
     "width": 0.46563
   },
   {
@@ -491,7 +491,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "x",
+            "text": "x",
             "width": 0.65903
           },
           {
@@ -506,7 +506,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "y",
+            "text": "y",
             "width": 0.59028
           },
           {
@@ -521,7 +521,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
             "skew": 0,
             "style": {
             },
-            "value": "z",
+            "text": "z",
             "width": 0.55509
           }
         ],
@@ -556,7 +556,7 @@ exports[`A font parser \\boldsymbol should inherit mbin/mrel from argument 1`] =
     "skew": 0.16667,
     "style": {
     },
-    "value": "f",
+    "text": "f",
     "width": 0.48959
   }
 ]
@@ -569,13 +569,13 @@ exports[`A parse tree generator generates a tree 1`] = `
     "base": {
       "type": "mathord",
       "mode": "math",
-      "value": "\\\\sigma"
+      "text": "\\\\sigma"
     },
     "mode": "math",
     "sup": {
       "type": "textord",
       "mode": "math",
-      "value": "2"
+      "text": "2"
     }
   }
 ]
@@ -598,7 +598,7 @@ exports[`A parser that does not throw on unsupported commands should build katex
       "skew": 0,
       "style": {
       },
-      "value": "2^2^2",
+      "text": "2^2^2",
       "width": 0
     }
   ],
@@ -635,7 +635,7 @@ exports[`An implicit group parser within optional groups should work style comma
         {
           "type": "mathord",
           "mode": "math",
-          "value": "x"
+          "text": "x"
         }
       ]
     },
@@ -649,7 +649,7 @@ exports[`An implicit group parser within optional groups should work style comma
             {
               "type": "textord",
               "mode": "math",
-              "value": "3"
+              "text": "3"
             }
           ],
           "mode": "math",
@@ -673,7 +673,7 @@ exports[`An implicit group parser within optional groups should work with \\colo
         {
           "type": "mathord",
           "mode": "math",
-          "value": "x"
+          "text": "x"
         }
       ]
     },
@@ -687,7 +687,7 @@ exports[`An implicit group parser within optional groups should work with \\colo
             {
               "type": "textord",
               "mode": "math",
-              "value": "3"
+              "text": "3"
             }
           ],
           "color": "red",
@@ -711,7 +711,7 @@ exports[`An implicit group parser within optional groups should work with old fo
         {
           "type": "mathord",
           "mode": "math",
-          "value": "x"
+          "text": "x"
         }
       ]
     },
@@ -728,7 +728,7 @@ exports[`An implicit group parser within optional groups should work with old fo
               {
                 "type": "textord",
                 "mode": "math",
-                "value": "3"
+                "text": "3"
               }
             ]
           },
@@ -753,7 +753,7 @@ exports[`An implicit group parser within optional groups should work with sizing
         {
           "type": "mathord",
           "mode": "math",
-          "value": "x"
+          "text": "x"
         }
       ]
     },
@@ -767,7 +767,7 @@ exports[`An implicit group parser within optional groups should work with sizing
             {
               "type": "textord",
               "mode": "math",
-              "value": "3"
+              "text": "3"
             }
           ],
           "mode": "math",

test/katex-spec.js

@@ -596,10 +596,10 @@ describe("An over/brace/brack parser", function() {
         const parse = getParsed(nestedOverExpression)[0];
         expect(parse.type).toEqual("genfrac");
         expect(parse.numer.value[0].type).toEqual("genfrac");
-        expect(parse.numer.value[0].numer.value[0].value).toEqual("1");
-        expect(parse.numer.value[0].denom.value[0].value).toEqual("2");
+        expect(parse.numer.value[0].numer.value[0].text).toEqual("1");
+        expect(parse.numer.value[0].denom.value[0].text).toEqual("2");
         expect(parse.denom).toBeDefined();
-        expect(parse.denom.value[0].value).toEqual("3");
+        expect(parse.denom.value[0].text).toEqual("3");
     });
 
     it("should fail with multiple overs in the same group", function() {
@@ -711,7 +711,7 @@ describe("A text parser", function() {
         const parse = getParsed(leadingSpaceTextExpression)[0];
         // [m, o, o]
         expect(parse.body).toHaveLength(3);
-        expect(parse.body.map(n => n.value).join("")).toBe("moo");
+        expect(parse.body.map(n => n.text).join("")).toBe("moo");
     });
 
     it("should parse math within text group", function() {
@@ -1089,14 +1089,14 @@ describe("A non-braced kern parser", function() {
         const abParse3 = getParsed(abKern3);
 
         expect(abParse1).toHaveLength(3);
-        expect(abParse1[0].value).toEqual("a");
-        expect(abParse1[2].value).toEqual("b");
+        expect(abParse1[0].text).toEqual("a");
+        expect(abParse1[2].text).toEqual("b");
         expect(abParse2).toHaveLength(3);
-        expect(abParse2[0].value).toEqual("a");
-        expect(abParse2[2].value).toEqual("b");
+        expect(abParse2[0].text).toEqual("a");
+        expect(abParse2[2].text).toEqual("b");
         expect(abParse3).toHaveLength(3);
-        expect(abParse3[0].value).toEqual("a");
-        expect(abParse3[2].value).toEqual("b");
+        expect(abParse3[0].text).toEqual("a");
+        expect(abParse3[2].text).toEqual("b");
     });
 
     it("should not parse invalid units", function() {
@@ -1119,9 +1119,9 @@ describe("A non-braced kern parser", function() {
         const abParse = getParsed(abKern);
 
         expect(abParse).toHaveLength(3);
-        expect(abParse[0].value).toEqual("a");
+        expect(abParse[0].text).toEqual("a");
         expect(abParse[1].dimension.unit).toEqual("mu");
-        expect(abParse[2].value).toEqual("b");
+        expect(abParse[2].text).toEqual("b");
     });
 });
 
@@ -1474,7 +1474,7 @@ describe("A style change parser", function() {
         const displayBody = displayNode.body;
 
         expect(displayBody).toHaveLength(2);
-        expect(displayBody[0].value).toEqual("e");
+        expect(displayBody[0].text).toEqual("e");
     });
 });
 
@@ -1547,10 +1547,10 @@ describe("A font parser", function() {
         expect(bf.type).toEqual("font");
         expect(bf.font).toEqual("mathbf");
         expect(bf.body.value).toHaveLength(3);
-        expect(bf.body.value[0].value).toEqual("a");
+        expect(bf.body.value[0].text).toEqual("a");
         expect(bf.body.value[1].type).toEqual("font");
         expect(bf.body.value[1].font).toEqual("mathrm");
-        expect(bf.body.value[2].value).toEqual("c");
+        expect(bf.body.value[2].text).toEqual("c");
     });
 
     it("should have the correct greediness", function() {