Fix \underset (#1277)

* Fix \underset

This PR modifies `\underset` and `\overset` to align with LaTeX behavior when a superscript is applied after the `\underset`.  Fixes issue #1275.

I also changed the spacing from KaTeX `mop` to KaTeX `rmel`. The result seems to be a closer visual match to LaTeX.

* Update screenshots

src/functions.js

@@ -62,26 +62,26 @@ defineFunction([
     };
 });
 
-// Build a relation by placing one symbol on top of another
+// Build a relation or stacked op by placing one symbol on top of another
-defineFunction(["\\stackrel"], {
+defineFunction(["\\stackrel", "\\overset", "\\underset"], {
     numArgs: 2,
 }, function(context, args) {
-    const top = args[0];
+    const mathAxisArg = args[1];
-    const bottom = args[1];
+    const shiftedArg = args[0];
 
-    const bottomop = new ParseNode("op", {
+    const xAxisOp = new ParseNode("op", {
         type: "op",
         limits: true,
         alwaysHandleSupSub: true,
         symbol: false,
-        value: ordargument(bottom),
+        value: ordargument(mathAxisArg),
-    }, bottom.mode);
+    }, mathAxisArg.mode);
 
     const supsub = new ParseNode("supsub", {
-        base: bottomop,
+        base: xAxisOp,
-        sup: top,
+        sup: context.funcName === "\\underset" ? null : shiftedArg,
-        sub: null,
+        sub: context.funcName === "\\underset" ? shiftedArg : null,
-    }, top.mode);
+    }, shiftedArg.mode);
 
     return {
         type: "mclass",

src/macros.js

@@ -169,10 +169,6 @@ defineMacro("\\varPhi", "\\mathit{\\Phi}");
 defineMacro("\\varPsi", "\\mathit{\\Psi}");
 defineMacro("\\varOmega", "\\mathit{\\Omega}");
 
-// \def\overset#1#2{\binrel@{#2}\binrel@@{\mathop{\kern\z@#2}\limits^{#1}}}
-defineMacro("\\overset", "\\mathop{#2}\\limits^{#1}");
-defineMacro("\\underset", "\\mathop{#2}\\limits_{#1}");
-
 // \newcommand{\boxed}[1]{\fbox{\m@th$\displaystyle#1$}}
 defineMacro("\\boxed", "\\fbox{\\displaystyle{#1}}");
 

test/katex-spec.js

@@ -2779,11 +2779,9 @@ describe("A macro expander", function() {
     });
 */
 
-    it("should expand the \\overset macro as expected", function() {
+    it("should build \\overset and \\underset", function() {
-        expect("\\overset?=").toParseLike("\\mathop{=}\\limits^{?}");
+        expect("\\overset{f}{\\rightarrow} Y").toBuild();
-        expect("\\overset{x=y}{\\sqrt{ab}}")
+        expect("\\underset{f}{\\rightarrow} Y").toBuild();
-            .toParseLike("\\mathop{\\sqrt{ab}}\\limits^{x=y}");
-        expect("\\overset {?} =").toParseLike("\\mathop{=}\\limits^{?}");
     });
 
     it("should build \\iff, \\implies, \\impliedby", function() {

test/screenshotter/ss_data.yaml

@@ -218,7 +218,7 @@ OpLimits: |
 OverUnderline: x\underline{x}\underline{\underline{x}}\underline{x_{x_{x_x}}}\underline{x^{x^{x^x}}}\overline{x}\overline{x}\overline{x^{x^{x^x}}} \blue{\overline{\underline{x}}\underline{\overline{x}}}
 OverUnderset: |
     \begin{array}{l}
-    x\overset?=1\\
+    x\overset?=1 \quad \underset{*}{x}^2 \\
     {\displaystyle\lim_{t\underset{>0}\to0}}\\
     a+b+c+d\overset{b+c=0}\longrightarrow a+d\\
     \overset { x = y } { \sqrt { a b } }