patrick/KaTeX
1
0
Fork 0
mirror of https://github.com/Smaug123/KaTeX synced 2025-10-09 13:08:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix delimiter error message (#2186)

Browse Source 
* Fix delimiter error message

Avoid "circular structure" error message by avoiding JSON.stringify on a
parse structure when getting an invalid delimiter type (e.g. ordgroup).
Instead, report type of delimiter when it's invalid.  Fixes #2184.

* Fix and add tests
This commit is contained in:
Erik Demaine
2020-01-04 04:10:11 -05:00
committed by ylemkimon
parent 754e79a12e
commit 3cb9bd78bb
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/functions/delimsizing.js
View File

@@ -62,11 +62,12 @@ function checkDelimiter(
const symDelim = checkSymbolNodeType(delim); const symDelim = checkSymbolNodeType(delim);
if (symDelim && utils.contains(delimiters, symDelim.text)) { if (symDelim && utils.contains(delimiters, symDelim.text)) {
return symDelim; return symDelim;
} else { } else if (symDelim) {
throw new ParseError( throw new ParseError(
"Invalid delimiter: '" + `Invalid delimiter '${symDelim.text}' after '${context.funcName}'`,
(symDelim ? symDelim.text : JSON.stringify(delim)) + delim);
"' after '" + context.funcName + "'", delim); } else {
throw new ParseError(`Invalid delimiter type '${delim.type}'`, delim);
} }
} }

14
test/errors-spec.js
View File

@@ -250,14 +250,24 @@ describe("functions.js:", function() {
describe("delimiter functions", function() { describe("delimiter functions", function() {
it("reject invalid opening delimiters", function() { it("reject invalid opening delimiters", function() {
expect`\bigl 1 + 2 \bigr`.toFailWithParseError( expect`\bigl 1 + 2 \bigr`.toFailWithParseError(
"Invalid delimiter: '1' after '\\bigl' at position 7:" + "Invalid delimiter '1' after '\\bigl' at position 7:" +
" \\bigl 1̲ + 2 \\bigr"); " \\bigl 1̲ + 2 \\bigr");
}); });
it("reject invalid closing delimiters", function() { it("reject invalid closing delimiters", function() {
expect`\bigl(1+2\bigr=3`.toFailWithParseError( expect`\bigl(1+2\bigr=3`.toFailWithParseError(
"Invalid delimiter: '=' after '\\bigr' at position 15:" + "Invalid delimiter '=' after '\\bigr' at position 15:" +
" \\bigl(1+2\\bigr=̲3"); " \\bigl(1+2\\bigr=̲3");
}); });
it("reject group opening delimiters", function() {
expect`\bigl{(}1+2\bigr)3`.toFailWithParseError(
"Invalid delimiter type 'ordgroup' at position 6:" +
" \\bigl{̲(̲}̲1+2\\bigr)3");
});
it("reject group closing delimiters", function() {
expect`\bigl(1+2\bigr{)}3`.toFailWithParseError(
"Invalid delimiter type 'ordgroup' at position 15:" +
" \\bigl(1+2\\bigr{̲)̲}̲3");
});
}); });
describe("\\begin and \\end", function() { describe("\\begin and \\end", function() {