diff --git a/src/common.jl b/src/common.jl index e50681f..244c547 100644 --- a/src/common.jl +++ b/src/common.jl @@ -3,30 +3,18 @@ function letters_only(text::AbstractString) return filter(x -> ('A' <= x <= 'Z' || 'a' <= x <= 'z'), text) end -function rotate_right(arr::AbstractVector, n::Integer) - # implementation of the Mathematica function rotate_right - or you could try circshift()? - ans = copy(arr) - for i in 1:length(arr) - ans[i] = arr[((2*length(ans)+i-n-1) % length(ans)) + 1] - end - - return ans +rotate_left(arr::AbstractVector, n::Integer) = circshift(arr, -n) +rotate_right(arr::AbstractVector, n::Integer) = circshift(arr, n) + +function rotate_string(str::AbstractString, n::Integer) + i = mod(n, length(str)) + return str[i+1:end] * str[1:i] end -function rotate_left(arr::AbstractVector, n::Integer) - # implementation of the Mathematica function rotate_left - ans = copy(arr) - for i in 1:length(arr) - ans[i] = arr[((i + n - 1) % length(ans)) + 1] - end - - return ans -end - -rotate_left_str(st::AbstractString, n::Integer) = - join(rotate_left(collect(st), n)) -rotate_right_str(st::AbstractString, n::Integer) = - join(rotate_right(collect(st), n)) +rotate_left(str::AbstractString, n::Integer) = + rotate_string(str, n) +rotate_right(str::AbstractString, n::Integer) = + rotate_string(str, -n) function split_by(arr::AbstractVector, func::Function) # implementation of the Mathematica function split_by diff --git a/test/common.jl b/test/common.jl new file mode 100644 index 0000000..ac9313b --- /dev/null +++ b/test/common.jl @@ -0,0 +1,19 @@ +@test ClassicalCiphers.letters_only("Se9Wj8NK2:'n") == "SeWjNKn" + +@test ClassicalCiphers.rotate_left([78, 18, 53, 96, 15, 35, 72, 29, 34, 26], 3) == [96, 15, 35, 72, 29, 34, 26, 78, 18, 53] +@test ClassicalCiphers.rotate_right([78, 18, 53, 96, 15, 35, 72, 29, 34, 26], 3) == [29, 34, 26, 78, 18, 53, 96, 15, 35, 72] + +@test ClassicalCiphers.rotate_string("Se9Wj8NK2:'n", 5) == "8NK2:'nSe9Wj" +@test ClassicalCiphers.rotate_left("Se9Wj8NK2:'n", 3) == "Wj8NK2:'nSe9" +@test ClassicalCiphers.rotate_right("Se9Wj8NK2:'n", 3) == ":'nSe9Wj8NK2" + +@test ClassicalCiphers.split_by([78, 18, 53, 96, 15, 35, 72, 29, 34, 26], x -> x > 52) == [[78], [18], [53, 96], [15, 35], [72], [29, 34, 26]] + +# @test get_trigram_fitness() # I don't think we need this test because the function in question is immediately called and used in ../src/common.jl + +@test ClassicalCiphers.string_fitness("Se9Wj8NK2:'n") == 11.640550700535616 + +# @test ClassicalCiphers.frequencies("hello") == Dict('h' => 1, 'e' => 1, 'l' => 2, 'o' => 1) + +@test ClassicalCiphers.index_of_coincidence("hello world") == 0.5777777777777777 +@test ClassicalCiphers.index_of_coincidence("smaug123classicalciphers") == 0.6190476190476191 diff --git a/test/runtests.jl b/test/runtests.jl index 23b7857..6864fa8 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -2,6 +2,7 @@ include(joinpath(dirname(@__DIR__), "src", "ClassicalCiphers.jl")); using .Class using Test tests = [ + "common", "playfair", "vigenere", "monoalphabetic",